feat: Add bigframes.pandas.col with basic operators#2405
Open
TrevorBergeron wants to merge 4 commits intomainfrom
Open
feat: Add bigframes.pandas.col with basic operators#2405TrevorBergeron wants to merge 4 commits intomainfrom
TrevorBergeron wants to merge 4 commits intomainfrom
Conversation
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: m
sycai
reviewed
Feb 5, 2026
| "new_col_1": 4 - pd.col("int64_col"), # type: ignore | ||
| "new_col_2": pd.col("int64_col") / (pd.col("float64_col") * 0.5), # type: ignore | ||
| } | ||
| df = scalars_df.assign(**bf_kwargs) |
Contributor
There was a problem hiding this comment.
style nit: an empty line above to separate "arrange" and "act" block
| import bigframes.operations as bf_ops | ||
|
|
||
|
|
||
| # Not to be confused with internal Expressions class |
Contributor
There was a problem hiding this comment.
nit:
... confused with
internal Expression class
=>
... confused with the Expression class under
bigframes.core
| assert_frame_equal(bf_result, pd_result) | ||
|
|
||
|
|
||
| def test_assign_using_pd_col(scalars_dfs): |
Contributor
There was a problem hiding this comment.
non-rhetorical question: what's your thought on providing full test coverage for all the operators you have introduced in this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕